Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Updating of CI-tests #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dmitry-lipetsk
Copy link
Collaborator

This patch request has two goals:

  • Run CI-tests on the different platforms
  • Run tests for remote connection (through SSH) in CI

Including of 'postgres' in 'sudo' group is not required.
A problem was detected in container with Ubuntu 24.04

tests works with "/usr/bin/pg_config" but real pg_config is "/usr/lib/postgresql/17/bin/pg_config"

To resovle this problem we will call "pg_config --bindir" and use it result for BINDIR and PG_CONFIG.
Let's use /pg/testgres/run_tests.sh directly.
/pg/testgres/run_tests.sh is used directly.
- We do multiple attempts to read pid file.
- We process a case when we see that node is stopped between test and read.
- We process a case when pid-file is empty.
- New parameters "ignore_errors" is added. Default value is False.
- Asserts are added.
This method returns nothing (None).
When we define a template we have to use "-t" option. It forces mktemp to return a path instead name.

The following methods of RemoteOperations are fixed:
 - mkdtemp
 - mkstemp
Main
 - We check only an exit code to detect an error.
 - If someone utility returns a result through an exit code, a caller side should set ignore_errors=true and process this case itself.
 - If expect_error is true and no errors occurred, we raise an InvalidOperationException.
The folder "home/postgres" is not required now.
Let's rollback the new code to avoid problems with probackup2' tests.
- these tests configure logging wrong and create the conflicts with root logger
- these tests (local and remote) conflict with each other
@dmitry-lipetsk dmitry-lipetsk merged commit e1a5bb4 into postgrespro:master Mar 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant